-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Fixes #315
Some Fixes #315
Conversation
This reverts commit 88d77b3.
When valid web url selected, the url opens directly instead of searching in Search Engine.
@Jasonstein I noticed the RTL/LTR switch only works for current line. Is it intended behaviour?? |
Hi @soumyamahunt , Can you separate your PR into small PRs? It is easier for me to review and I can put it on hold and decide which one to go in for each release. Since it will be harder to debug issues if we jam too many things in one release. Just my 2 cents. Thanks! As well for the logging feature, If we add it, we should provide a setting for user to turn on and off. I still do not think it is a feature that will reach to most people. I want to keep Notepads as simple as it is at this current stage. Even for the markdown preview and diff viewer feature, there is only less than 5% of the user base have ever used. |
For RTL: you need to do ctrl+A first. |
I have separated the pull requests, plz look into it when you have time.
I am thinking of adding a toggle in advanced settings section. Should I enable this feature by default?? |
Have you looked into this, might make your work easier. |
These issues/requests have been added and should be closed:
#236, #197, #17
Also fixed AppBarButton, superscript toggle on "Ctrl+Shift+="

Added some new styles.