Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Fixes #315

Closed
wants to merge 21 commits into from
Closed

Some Fixes #315

wants to merge 21 commits into from

Conversation

soumyamahunt
Copy link
Contributor

These issues/requests have been added and should be closed:
#236, #197, #17

Also fixed AppBarButton, superscript toggle on "Ctrl+Shift+="
2020-03-02_13-34-45

Added some new styles.

@soumyamahunt
Copy link
Contributor Author

@Jasonstein I noticed the RTL/LTR switch only works for current line. Is it intended behaviour??
Also Can you tell how periodic markdown rendering will be helpful compared to what we have now??

@0x7c13
Copy link
Owner

0x7c13 commented Mar 3, 2020

Hi @soumyamahunt , Can you separate your PR into small PRs? It is easier for me to review and I can put it on hold and decide which one to go in for each release. Since it will be harder to debug issues if we jam too many things in one release. Just my 2 cents. Thanks!

As well for the logging feature, If we add it, we should provide a setting for user to turn on and off. I still do not think it is a feature that will reach to most people. I want to keep Notepads as simple as it is at this current stage. Even for the markdown preview and diff viewer feature, there is only less than 5% of the user base have ever used.

@0x7c13
Copy link
Owner

0x7c13 commented Mar 3, 2020

@Jasonstein I noticed the RTL/LTR switch only works for current line. Is it intended behaviour??
Also Can you tell how periodic markdown rendering will be helpful compared to what we have now??

For RTL: you need to do ctrl+A first.
For periodic, if the markdown file is huge in size (thousand of lines), it will become super slow to edit anything if periodic fetching and rendering is not enabled. I have a sample code already to handle it. You can leave it to me.

@soumyamahunt
Copy link
Contributor Author

Hi @soumyamahunt , Can you separate your PR into small PRs? It is easier for me to review and I can put it on hold and decide which one to go in for each release. Since it will be harder to debug issues if we jam too many things in one release. Just my 2 cents. Thanks!

I have separated the pull requests, plz look into it when you have time.

As well for the logging feature, If we add it, we should provide a setting for user to turn on and off. I still do not think it is a feature that will reach to most people. I want to keep Notepads as simple as it is at this current stage. Even for the markdown preview and diff viewer feature, there is only less than 5% of the user base have ever used.

I am thinking of adding a toggle in advanced settings section. Should I enable this feature by default??

@soumyamahunt
Copy link
Contributor Author

For periodic, if the markdown file is huge in size (thousand of lines), it will become super slow to edit anything if periodic fetching and rendering is not enabled. I have a sample code already to handle it. You can leave it to me.

Have you looked into this, might make your work easier.

@soumyamahunt soumyamahunt deleted the fixes branch March 3, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants