Skip to content

chore: bump thornode image: update to 1.0.27-23761879 (dev)#83

Open
tiljrd wants to merge 1 commit intodevfrom
bump-thornode-1.0.27-23761879-dev
Open

chore: bump thornode image: update to 1.0.27-23761879 (dev)#83
tiljrd wants to merge 1 commit intodevfrom
bump-thornode-1.0.27-23761879-dev

Conversation

@tiljrd
Copy link
Copy Markdown
Contributor

@tiljrd tiljrd commented Dec 27, 2025

User description

Automated: bump image to tiljordan/thornode-forking:1.0.27-23761879 on base dev. Automated weekly bump.


PR Type

Other


Description

  • Update thornode-forking image from 1.0.25 to 1.0.27

  • Bump applied across configuration files and examples

  • Update default image in toolchain CLI Dockerfile


Diagram Walkthrough

flowchart LR
  A["thornode-forking<br/>1.0.25-23761879"] -- "upgrade to" --> B["thornode-forking<br/>1.0.27-23761879"]
  B --> C["Configuration Files"]
  B --> D["Example Files"]
  B --> E["Dockerfile"]
Loading

File Walkthrough

Relevant files
Configuration changes
README.md
Update README thornode image references                                   

README.md

  • Update forking image reference from 1.0.25 to 1.0.27
  • Update participants image reference from 1.0.25 to 1.0.27
+2/-2     
cli-with-network.yaml
Update CLI example image version                                                 

examples/cli-with-network.yaml

  • Update participant image from 1.0.25 to 1.0.27
+1/-1     
forking-1.0.10.yaml
Update forking example image version                                         

examples/forking-1.0.10.yaml

  • Update participant image from 1.0.25 to 1.0.27
+1/-1     
forking-genesis.yaml
Update genesis forking example images                                       

examples/forking-genesis.yaml

  • Update forking image from 1.0.25 to 1.0.27
  • Update participant image from 1.0.25 to 1.0.27
+2/-2     
faucet_launcher.star
Update faucet launcher image version                                         

src/faucet/faucet_launcher.star

  • Update faucet_image variable from 1.0.25 to 1.0.27
+1/-1     
single_node_launcher.star
Update single node launcher image                                               

src/network_launcher/single_node_launcher.star

  • Update default forking_image from 1.0.25 to 1.0.27
+1/-1     
thorchain_defaults.json
Update thorchain defaults image references                             

src/package_io/thorchain_defaults.json

  • Update participant image from 1.0.25 to 1.0.27
  • Update forking configuration image from 1.0.25 to 1.0.27
+2/-2     
Dependencies
Dockerfile
Update toolchain CLI base image                                                   

src/toolchain-cli/Dockerfile

  • Update base image FROM clause from 1.0.25 to 1.0.27
+1/-1     

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-thornode-1.0.27-23761879-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Container image supply chain

Description: The PR updates multiple runtime/base container image references to
tiljordan/thornode-forking:1.0.27-23761879 (e.g., this Dockerfile FROM plus several
YAML/Star/JSON configs) without pinning to an immutable digest (e.g., @sha256:...), which
can allow a tag to be overwritten upstream and silently introduce compromised or
unexpected images into builds and deployments. Dockerfile [1-1]

Referred Code
FROM tiljordan/thornode-forking:1.0.27-23761879
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Copy Markdown

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Centralize hardcoded image version string

Centralize the hardcoded thornode-forking image version into a shared constant
file and import it where needed to improve maintainability and prevent
inconsistencies.

src/network_launcher/single_node_launcher.star [12]

-forking_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.27-23761879")
+constants = import_module("../constants.star")
+forking_image = forking_config.get("image", constants.THORNODE_FORKING_IMAGE)
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies a significant maintainability issue, evidenced by the PR's widespread changes, and proposes a practical solution to centralize the hardcoded image version.

Medium
Avoid hardcoding version in defaults

Replace the hardcoded image version in the JSON file with a placeholder and use
a templating system to substitute the value from a central source, improving
maintainability.

src/package_io/thorchain_defaults.json [53-76]

 "participants": [
   {
     "type": "full",
     "count": 1,
-    "image": "tiljordan/thornode-forking:1.0.27-23761879",
+    "image": "{{ THORNODE_FORKING_IMAGE }}",
     "account_balance": 1000000000000,
     "bond_amount": 500000000000,
     "min_cpu": 1000,
     "min_memory": 8192,
     "gomemlimit": "7GiB"
   }
 ],
 "additional_services": [
   "faucet",
   "bdjuno"
 ],
 "forking": {
   "enabled": true,
-  "image": "tiljordan/thornode-forking:1.0.27-23761879",
+  "image": "{{ THORNODE_FORKING_IMAGE }}",
   "grpc": "grpc.thor.pfc.zone:443",
   "chain_id": "thorchain-1",
   "height": 23043758,
   "diffs_api_base": "https://thorchain.bloctopus.io/bloctopus/diffs",
   "state_repo_base": "https://thorchain-genesis.s3.amazonaws.com"
 },

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 7

__

Why: This suggestion correctly identifies the maintainability issue of a hardcoded image version in a default configuration file and proposes a valid templating solution to centralize it.

Medium
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant