chore: bump thornode image: update to 1.0.22-23761879 (main)

[tiljrd]

User description

Automated: bump image to tiljordan/thornode-forking:1.0.22-23761879 on base main. Automated weekly bump.

---

PR Type

Other

---

Description

• Downgrade thornode-forking image from 1.0.25 to 1.0.22

• Update image references across configuration files

• Update default image in JSON configuration

• Update Dockerfile base image reference

---

Diagram Walkthrough

flowchart LR
  A["thornode-forking<br/>1.0.25-23761879"] -- "downgrade to" --> B["thornode-forking<br/>1.0.22-23761879"]
  B --> C["README.md"]
  B --> D["Configuration Files"]
  B --> E["Dockerfile"]
  B --> F["JSON Defaults"]

Loading

File Walkthrough

Relevant files

Configuration changes

README.md Update thornode image references in README                              README.md Updated forking image reference from 1.0.25 to 1.0.22 Updated participants image reference from 1.0.25 to 1.0.22 +2/-2      cli-with-network.yaml Downgrade example CLI network configuration                            examples/cli-with-network.yaml Downgraded thornode-forking image from 1.0.25 to 1.0.22 in participants section +1/-1      forking-1.0.10.yaml Downgrade forking example configuration                                    examples/forking-1.0.10.yaml Downgraded thornode-forking image from 1.0.25 to 1.0.22 +1/-1      forking-genesis.yaml Downgrade forking genesis example configuration                    examples/forking-genesis.yaml Updated forking image reference from 1.0.25 to 1.0.22 Updated participants image reference from 1.0.25 to 1.0.22 +2/-2      faucet_launcher.star Downgrade faucet launcher image version                                    src/faucet/faucet_launcher.star Downgraded faucet_image variable from 1.0.25 to 1.0.22 +1/-1      single_node_launcher.star Downgrade single node launcher default image                          src/network_launcher/single_node_launcher.star Updated default forking_image from 1.0.25 to 1.0.22 +1/-1      thorchain_defaults.json Downgrade default thorchain configuration images                  src/package_io/thorchain_defaults.json Updated participants image from 1.0.25 to 1.0.22 Updated forking image from 1.0.25 to 1.0.22 +2/-2      Dockerfile Downgrade toolchain CLI Dockerfile base image                        src/toolchain-cli/Dockerfile Updated base image FROM clause from 1.0.25 to 1.0.22 +1/-1

---

Summary by CodeRabbit

• Chores
  • Updated system container image versions across configuration files, deployment examples, and toolchain components to maintain compatibility and operational consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR systematically downgrades the tiljordan/thornode-forking container image tag from 1.0.25-23761879 to 1.0.22-23761879 across documentation, example configurations, launcher scripts, package defaults, and Docker configuration files.

Changes

Cohort / File(s)	Change Summary
Documentation README.md	Updated image references in documentation from 1.0.25-23761879 to 1.0.22-23761879
Example YAML Configurations examples/cli-with-network.yaml, examples/forking-1.0.10.yaml, examples/forking-genesis.yaml	Downgraded thornode-forking image tag to 1.0.22-23761879 in example configs (multiple occurrences in genesis example)
Launcher Source Files src/faucet/faucet_launcher.star, src/network_launcher/single_node_launcher.star	Updated default image tag used by faucet and single-node launchers to 1.0.22-23761879
Configuration & Tooling src/package_io/thorchain_defaults.json, src/toolchain-cli/Dockerfile	Downgraded thornode-forking image in defaults config and toolchain Docker image

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore: bump thornode image: update to 1.0.25-23761879 (main) #79: Modifies the same thornode-forking image references but in the opposite direction (bumps to 1.0.25 while this reverts to 1.0.22)
• Docs + chain id fixes #54: Performs comprehensive updates to the same image tag across README, examples, launchers, defaults, and Dockerfile
• chore: bump thornode image: update to 1.0.20-23621657 (main) #63: Updates identical image reference fields (forking.image, participants[0].image) and related configuration files

Suggested labels

Review effort 2/5

Poem

🐰 A rabbit hops through versions past,
From point-two-five back down at last,
To point-two-two, the images gleam,
Across the config, launcher dream,
One tag to bind them, old and new! 🔗

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: updating the thornode Docker image to version 1.0.22-23761879.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bump-thornode-1.0.22-23761879-main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
⚪	Unpinned container image Description: The PR updates multiple container image references to tiljordan/thornode-forking:1.0.22-23761879 using a mutable tag (not pinned by digest), which creates a realistic supply-chain risk where the tag could be overwritten to deliver unexpected or malicious content (also referenced in README.md, examples/*.yaml, src/faucet/faucet_launcher.star, src/network_launcher/single_node_launcher.star, and src/package_io/thorchain_defaults.json). Dockerfile [1-1] Referred Code FROM tiljordan/thornode-forking:1.0.22-23761879
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Centralize hardcoded image version string To improve maintainability, centralize the hardcoded thornode-forking image version by reading it from a configuration file instead of hardcoding it in the script. src/faucet/faucet_launcher.star [32-33] # Use thornode forking image to get thornode CLI in container -faucet_image = "tiljordan/thornode-forking:1.0.22-23761879" +faucet_image = chain_cfg.get("forking", {}).get("image") Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies the issue of a hardcoded image version and proposes centralizing it, which would improve maintainability. The proposed change is valid and would prevent future inconsistencies.	Medium
	Centralize hardcoded default image version Remove the hardcoded default for the thornode-forking image and instead rely on a centralized configuration to provide this value, ensuring a single source of truth. src/network_launcher/single_node_launcher.star [11-12] forking_config = chain_cfg.get("forking", {}) -forking_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.22-23761879") +forking_image = forking_config.get("image") Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly points out the issue of a hardcoded default image version and recommends removing it to rely on a centralized configuration. This is a good practice for maintainability.	Medium
More

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @src/toolchain-cli/Dockerfile:
- Line 1: The Dockerfile's FROM line was changed to use
tiljordan/thornode-forking:1.0.22-23761879 (previously 1.0.25-23761879); verify
and document why this appears to be a downgrade by checking the upstream image
registry and thornode/tiljordan release notes, confirm whether 1.0.25-23761879
was removed or has a known critical issue, and if so update the PR description
or commit message with the justification (or restore the original tag if the
downgrade was accidental); reference the Dockerfile's FROM instruction and the
specific image tags (tiljordan/thornode-forking:1.0.22-23761879 and
tiljordan/thornode-forking:1.0.25-23761879) when making the verification and
updating the PR.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 414ef54 and eac788b.

📒 Files selected for processing (8)

• README.md
• examples/cli-with-network.yaml
• examples/forking-1.0.10.yaml
• examples/forking-genesis.yaml
• src/faucet/faucet_launcher.star
• src/network_launcher/single_node_launcher.star
• src/package_io/thorchain_defaults.json
• src/toolchain-cli/Dockerfile

🔇 Additional comments (5)

src/network_launcher/single_node_launcher.star (1)

12-12: Image version downgrade is consistent with other files.

The default forking image has been updated to match the version in the Dockerfile and other configuration files. The downgrade concern applies here as well—please see the verification request in the Dockerfile review.

examples/forking-1.0.10.yaml (1)

5-5: Example configuration updated consistently.

The example configuration reflects the same image version as the package defaults, maintaining consistency across documentation and examples.

src/package_io/thorchain_defaults.json (1)

57-57: Package defaults updated consistently.

Both the participant image and forking image references have been updated to the same version, maintaining internal consistency in the default configuration. This ensures all components use compatible image versions.

Also applies to: 71-71

README.md (1)

264-264: Documentation examples updated to match implementation.

The README examples now reflect the current default image versions, ensuring users who copy these examples will use the correct versions.

Also applies to: 267-267

examples/forking-genesis.yaml (1)

10-10: This is a newly added file, not a modification. The git history shows that examples/forking-genesis.yaml was created in this commit with the image tiljordan/thornode-forking:1.0.22-23761879. There is no previous version to downgrade from. Additionally, there is no 1.0.25-23761879 version found anywhere in the repository. The image tag exists on Docker Hub and is the current latest version available. The PR title accurately describes adding/updating this configuration file with the latest available image version.

Likely an incorrect or invalid review comment.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check the git history of the Dockerfile to see the previous version
git log --oneline src/toolchain-cli/Dockerfile | head -20

Repository: 0xBloctopus/thorchain-package

Length of output: 141

---

🏁 Script executed:

# Get the specific commit that changed this file
git log -p src/toolchain-cli/Dockerfile | head -100

Repository: 0xBloctopus/thorchain-package

Length of output: 55

---

🏁 Script executed:

# Check the current state and recent changes
git diff HEAD~5 HEAD -- src/toolchain-cli/Dockerfile

Repository: 0xBloctopus/thorchain-package

Length of output: 103

---

🏁 Script executed:

# Look for any PR or issue references in recent commits
git log --all --grep="thornode\|Dockerfile\|version\|bump" --oneline | head -20

Repository: 0xBloctopus/thorchain-package

Length of output: 1562

---

🏁 Script executed:

git show eac788b --no-patch

Repository: 0xBloctopus/thorchain-package

Length of output: 295

---

🏁 Script executed:

# Check for any related issues or PR discussions
git log eac788b^..eac788b --format=fuller

Repository: 0xBloctopus/thorchain-package

Length of output: 272

---

Verify the reason for this intentional version downgrade.

The change downgrades the base image from 1.0.25-23761879 to 1.0.22-23761879. The commit message indicates this is part of an "Automated weekly bump," suggesting the upstream image maintainer (tiljordan) has updated what is considered the stable version. However, this downgrade warrants clarification:

1. Was 1.0.25-23761879 intentionally yanked or removed from the registry?
2. Is there a documented reason for preferring 1.0.22 (e.g., critical bug in 1.0.25)?
3. Does the versioning scheme differ from standard semantic versioning (where 1.0.25 > 1.0.22)?

Confirm with the upstream maintainer or check the thornode release notes if there are known issues with 1.0.25.

🤖 Prompt for AI Agents

In @src/toolchain-cli/Dockerfile at line 1, The Dockerfile's FROM line was
changed to use tiljordan/thornode-forking:1.0.22-23761879 (previously
1.0.25-23761879); verify and document why this appears to be a downgrade by
checking the upstream image registry and thornode/tiljordan release notes,
confirm whether 1.0.25-23761879 was removed or has a known critical issue, and
if so update the PR description or commit message with the justification (or
restore the original tag if the downgrade was accidental); reference the
Dockerfile's FROM instruction and the specific image tags
(tiljordan/thornode-forking:1.0.22-23761879 and
tiljordan/thornode-forking:1.0.25-23761879) when making the verification and
updating the PR.