Skip to content

chore: bump thornode image: update to 1.0.22-23761879 (dev)#87

Open
tiljrd wants to merge 1 commit intodevfrom
bump-thornode-1.0.22-23761879-dev
Open

chore: bump thornode image: update to 1.0.22-23761879 (dev)#87
tiljrd wants to merge 1 commit intodevfrom
bump-thornode-1.0.22-23761879-dev

Conversation

@tiljrd
Copy link
Copy Markdown
Contributor

@tiljrd tiljrd commented Jan 10, 2026

User description

Automated: bump image to tiljordan/thornode-forking:1.0.22-23761879 on base dev. Automated weekly bump.


PR Type

Other


Description

  • Downgrade thornode-forking image from 1.0.25 to 1.0.22

  • Update image tag across configuration files and examples

  • Update default image in Dockerfile and JSON defaults

  • Automated weekly version bump process


Diagram Walkthrough

flowchart LR
  A["thornode-forking<br/>1.0.25-23761879"] -->|"downgrade to"| B["thornode-forking<br/>1.0.22-23761879"]
  B --> C["README.md"]
  B --> D["Configuration Files"]
  B --> E["Dockerfile"]
  B --> F["JSON Defaults"]
Loading

File Walkthrough

Relevant files
Configuration changes
README.md
Update thornode-forking image version in README                   

README.md

  • Updated forking image tag from 1.0.25 to 1.0.22
  • Updated participants image tag from 1.0.25 to 1.0.22
+2/-2     
cli-with-network.yaml
Update example CLI network configuration image                     

examples/cli-with-network.yaml

  • Downgraded thornode-forking image from 1.0.25 to 1.0.22
+1/-1     
forking-1.0.10.yaml
Update forking example image version                                         

examples/forking-1.0.10.yaml

  • Downgraded thornode-forking image from 1.0.25 to 1.0.22
+1/-1     
forking-genesis.yaml
Update forking genesis example image version                         

examples/forking-genesis.yaml

  • Updated forking image tag from 1.0.25 to 1.0.22
  • Updated participants image tag from 1.0.25 to 1.0.22
+2/-2     
faucet_launcher.star
Update faucet launcher image version                                         

src/faucet/faucet_launcher.star

  • Downgraded faucet_image variable from 1.0.25 to 1.0.22
+1/-1     
single_node_launcher.star
Update single node launcher default image                               

src/network_launcher/single_node_launcher.star

  • Updated default forking_image from 1.0.25 to 1.0.22
+1/-1     
thorchain_defaults.json
Update thorchain defaults image versions                                 

src/package_io/thorchain_defaults.json

  • Updated participants image from 1.0.25 to 1.0.22
  • Updated forking image from 1.0.25 to 1.0.22
+2/-2     
Dependencies
Dockerfile
Update toolchain CLI Dockerfile base image                             

src/toolchain-cli/Dockerfile

  • Updated base image FROM tag from 1.0.25 to 1.0.22
+1/-1     

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-thornode-1.0.22-23761879-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Unpinned container image

Description: The PR updates multiple configurations to use the mutable third-party container image
tiljordan/thornode-forking:1.0.22-23761879 (tag only, no digest pin), which is a
supply-chain risk because the tag can be retargeted to different content and could
introduce a compromised or vulnerable image at build/run time.
Dockerfile [1-1]

Referred Code
FROM tiljordan/thornode-forking:1.0.22-23761879
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Avoid hardcoding image version string

To improve maintainability, avoid hardcoding the faucet_image string. Instead,
retrieve it from the chain_cfg configuration, similar to the pattern used in
single_node_launcher.star.

src/faucet/faucet_launcher.star [32-33]

 # Use thornode forking image to get thornode CLI in container
-faucet_image = "tiljordan/thornode-forking:1.0.22-23761879"
+forking_config = chain_cfg.get("forking", {})
+faucet_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.22-23761879")
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies a hardcoded image version and proposes a good refactoring to fetch it from configuration, which would improve maintainability and prevent issues like the one this PR is fixing.

Medium
Use build argument for image tag

To improve maintainability, replace the hardcoded base image tag in the
Dockerfile with a build argument (ARG). This allows the version to be specified
during the build process.

src/toolchain-cli/Dockerfile [1]

-FROM tiljordan/thornode-forking:1.0.22-23761879
+ARG THORNODE_IMAGE_TAG=1.0.22-23761879
+FROM tiljordan/thornode-forking:${THORNODE_IMAGE_TAG}
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion proposes using a build argument for the base image tag, which is a standard best practice for Dockerfiles that enhances maintainability and simplifies version management.

Medium
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant