Combine mux constraints and use simplified bitstring algorithm for BigLessThan.#17
Open
BlakeMScurr wants to merge 3 commits into0xPARC:masterfrom
Open
Combine mux constraints and use simplified bitstring algorithm for BigLessThan.#17BlakeMScurr wants to merge 3 commits into0xPARC:masterfrom
BlakeMScurr wants to merge 3 commits into0xPARC:masterfrom
Conversation
Rather than using boolean logic, construct and compare two bit strings which represent the registers where a > b, and where b > a respectively. As well as simplifying the code, this removes 2 constraints where k=3 and 4 where k=4 for 256 bit big ints.
BlakeMScurr
changed the title
BlakeMScurr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was exploring this library I noticed some simple improvements.
The main change is replacing the boolean logic in
BigLessThanwith bit manipulation, which removes 2 constraints if we're using 3 registers, and 4 if we're using 4.All relevant tests are passing, though I didn't run the whole suite for fear of overheating my laptop.