Update to pod2 repo with prefixless wildcards#123
Merged
Conversation
regex: (?<!\w|trace(?:.|\n){0,100}|debug(?:.|\n){0,100}|https?://(?:.|\n){0,100})\?([A-Za-z]\w*)(?!\w|=)
replace with: $1
exclude files: *.cjs
robknight
approved these changes
Sep 24, 2025
…/pod2-repo-update # Conflicts: # core/new_solver/src/handlers/publickeyof.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PODLang breaking change removes ? from wildcards. This PR updates the pod2 repo pointer to the latest, and updates wildcards in this repo to the new format.
I did the replacement with a regex in VSCode. Unlike in the pod2 repo, I had to tweak it to avoid several classes of false-positives of things which look like PODLang wildcards but aren't. Documenting the regex I used for posterity, so that others can apply it on their own branches:
regex:
(?<!\w|trace(?:.|\n){0,100}|debug(?:.|\n){0,100}|https?://(?:.|\n){0,100})\?([A-Za-z]\w*)(?!\w|=)replace with:
$1exclude files:
*.cjsAs far as I can tell from local Rust tests and the GitHub workflow tests above, this seems to be correct.
I don't know how to build and run the PODNet Client myself, though, so I haven't tested beyond what's automated.
I'm not expecting a line-by-line review here since it's all automated. I'm hoping @robknight can quickly stanity-check any false-positives I may have missed, and confirm the client isn't entirely broken.