Repository navigation
Conversation
parent of /home/user/ stayed /home/user. The trailing separator was treated as a directory level, so one step up did not leave the directory. C:\Users\ stayed C:\Users.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemotePath::parentof/home/user/returned/home/user. The trailing separator was counted as a directory level, so one step up stayed in the same directory./home/returned/home.C:\Users\returnedC:\Users.C:\Users\npace\returnedC:\Users\npace.The directory picker uses this for the up action. A trailing separator is not a level.
/home/user/is now/home./home/is now/.C:\Users\is nowC:\.C:\Users\npace\is nowC:\Users./home/useris still/home.C:\Users\npaceis stillC:\Users.C:\is stillC:\.Test plan
parent_trailing_separator_is_not_a_levelfails on tip (/home/user/stays/home/user) and passes after the fixparent_posix,parent_windows, andparent_windows_forward_slashesstill pass, along with the rest of theremote_pathtests