Skip to content

forge fmt#102

Closed
pkieltyka wants to merge 1 commit intomasterfrom
forge-fmt
Closed

forge fmt#102
pkieltyka wants to merge 1 commit intomasterfrom
forge-fmt

Conversation

@pkieltyka
Copy link
Copy Markdown
Member

No description provided.

@pkieltyka pkieltyka marked this pull request as draft November 30, 2025 16:47
@ScreamingHawk
Copy link
Copy Markdown
Collaborator

Looks like the foundry line_length setting isn't being respected anymore.

https://github.com/0xsequence/wallet-contracts-v3/blob/master/foundry.toml#L25
https://getfoundry.sh/config/reference/formatter/#multiline_func_header

The multiline_func_header configuration option in Foundry controls how function headers (the line containing the function name, parameters, return values etc.) are formatted when they exceed the max line length.

@pkieltyka
Copy link
Copy Markdown
Member Author

I think this new formatting is more readable anyways :)

@Agusx1211
Copy link
Copy Markdown
Member

With this change we will need to redeploy every single contract again. So I think it's better to not include it.

With the event changes we only need to deploy two or three contracts.

@ScreamingHawk
Copy link
Copy Markdown
Collaborator

I agree let's skip this. It's not a necessary change this late in the game. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants