Repository navigation
Use fork of rust-verkle crates for improved commitment performance - #335
Merged
Merged
Conversation
This fork improves the performance of committing to vectors with a lot of zero-valued scalars, which frequently happens when updating commitments.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fork improves the performance of committing to vectors with a lot of zero-valued scalars, which frequently happens when updating commitments. I've opened a PR to upstream these changes, we can switch back to the original crate once/if that gets merged.
Performance for the first 100K blocks on sonic-bare-c improves from 118 MGas/s to 159 MGas/s.
Running for blocks 600K through 700K improves from 180 MGas/s to 362 MGas/s.