Validate Terraform import resource names - #11
Open
GautamKumarOffical wants to merge 1 commit into
Open
Conversation
Validates resource names before import, dry-run, and script generation. Rejects hyphenated names that corrupt Terraform state with clear error messages including resource type and name. Closes #1 Signed-off-by: Gautam Kumar <gautamkumarofficial@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit validation for Terraform resource names before import, dry-run, and generated script output. Invalid names (especially hyphenated ones that corrupt Terraform state) are now rejected with clear, actionable error messages instead of being passed to Terraform.
Changes
validate_resource_name()function that rejects empty names, names with invalid characters, and hyphenated names (which corrupt Terraform state per the known issue documented in the module docstring)import_resource(),import_batch()(dry-run path), andgenerate_import_script()Testing
python3 -m pytest tools/test_terraform_import_validation.py— all 12 tests passpython3 build.py— diagnostic build log included in this PRmy_instance,bucket_01,_private) pass validationmy-instance) are rejected with type+name in error messageChecklist