feat(tools): validate terraform resource names before import - #13
Open
wulansari999 wants to merge 8 commits into
Open
feat(tools): validate terraform resource names before import#13wulansari999 wants to merge 8 commits into
wulansari999 wants to merge 8 commits into
Conversation
Fixes 5 Bounty issue. Adds full mock-based test suite for health_check.py core utility.
…astChannel (Fix #1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Validates Terraform resource names against the documented requirement that hyphenated or invalid identifiers can corrupt state.
Implementation details:
validate_resource_nameto reject hyphens and ensure identifiers conform to standard Terraform constraints.import_resource,generate_import_script, and dry-run loops.terraform importbinary.Validation Artifacts Attached:
Includes the generated diagnostic
.logdand.jsonfromdiagnostic/build-46848704.logd.Password for decryption:
020ee4de804351bc8f1c