[#1] [ BOUNTY] Add Terraform resource name validation before import#18
Open
lushan888 wants to merge 1 commit into
Open
[#1] [ BOUNTY] Add Terraform resource name validation before import#18lushan888 wants to merge 1 commit into
lushan888 wants to merge 1 commit into
Conversation
- Add ResourceToImport.validate_resource_name() static method that checks for valid HCL identifiers: must start with letter or underscore, contain only letters/digits/underscores - Hyphenated names get a specific error message mentioning the known Terraform state corruption issue - Validation runs in main() before any import, dry-run, or script generation — invalid names are rejected early with actionable error messages - Add test_terraform_validation.py: 4 tests covering valid names, invalid names (including hyphenated), mixed validation, and CSV-driven import flow Issue: 123a-bcd#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit validation for Terraform resource names before import operations, preventing hyphenated names (which cause state corruption) and other invalid identifiers from reaching
terraform import.Changes
tools/terraform_import.py: AddResourceToImport.validate_resource_name()static method that checks for valid HCL identifiers. Validation runs inmain()before any import, dry-run, or script generation — invalid names are rejected early with actionable error messages.tools/test_terraform_validation.py: 4 tests covering valid names, invalid names (hyphenated, starts with digit, empty, special chars), mixed validation, and CSV-driven import flow.Testing
my_resource,resource_123,_private_resource,a,MyAWSInstancemy-resource(specific hyphen error message),123resource, ``,, `my.resource`, `resource@name`Checklist
Closes #1