Skip to content

fix: Tool folder #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: Tool folder #4281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/src/views/tool/component/ToolListContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ function openCreateDialog(data?: any) {
storeTools.value.filter((item) => item.id === data.template_id).forEach((item) => {
readMe = item.readMe
})
bus.emit('select_node', data.folder_id)
toolStoreDescDrawerRef.value?.open(readMe, data)
return
}
Expand All @@ -406,6 +407,7 @@ function openCreateDialog(data?: any) {
loadSharedApi({ type: 'tool', systemType: apiType.value })
.getToolById(data?.id, loading)
.then((res: any) => {
bus.emit('select_node', data.folder_id)
ToolFormDrawerRef.value.open(res.data)
})
} else {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given code appears to be part of an application where it handles two functions: openCreateDialog and another whose content is not fully provided. Here's an analysis and some suggestions for improvement:

Issues Found:

1. Code Duplication within openCreateDialog:

  • The first block uses bus.emit('select_node', data.folder_id) twice.
    This redundancy can be eliminated to improve readability.

2. Comments Consistency:

  • There are inconsistent comments, which might make the code harder to understand.

Suggested Improvements:

function openCreateDialog(data?: any) {
 if (data?.template_id) {
     const storeToolsValue = storeTools.value;
     storeToolsValue.filter((item) => item.id === data.template_id).forEach((item) => {
         readMe = item.readMe
     });
    
    // Emit select node signal only once
    bus.emit('select_node', data.folder_id);
   
    // Open tool description drawer
    toolStoreDescDrawerRef.value.open(readMe, data);
    return;
}

// Handle other cases if needed...

Additional Suggestions:

  • Consistent Naming: Ensure all variable names (storeTools, readMe, toolStoreDescDrawerRef) have consistent naming conventions.

  • Error Handling: Consider adding error handling around asynchronous operations like fetching from shared APIs, to manage potential errors gracefully.

  • Optimization: If there are many items filtering or processing in openCreateDialog, consider optimizing loops where possible to reduce computational overhead.

These changes focus on addressing duplication and improving readability while ensuring proper functionality.

Expand Down
Loading