Skip to content

fix: When the workflow does not respond, there is an error in the historical chat record data #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: When the workflow does not respond, there is an error in the historical chat record data #4282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/models/application_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import uuid_utils.compat as uuid
from django.contrib.postgres.fields import ArrayField
from django.db import models
from django.utils.translation import gettext_lazy as _
from django.utils.translation import gettext as _
from langchain_core.messages import HumanMessage, AIMessage

from application.models import Application
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears generally correct with one minor issue to note:

  1. Import Statements: The gettext function is used instead of gettext_lazy. While this works fine for simple applications where translation isn't a significant concern, it might not be ideal if the application needs better performance in larger scale or more complex scenarios.

    Instead, gettext_lazy should be preferred over gettext when translating because it allows for lazy loading of translations and can improve memory usage by avoiding unnecessary localization until translation strings are accessed.

Optimization Suggestion: Use gettext_lazy.

Here's how you can fix it:

@@ -9,7 +9,7 @@
 import uuid_utils.compat as uuid
 from django.contrib.postgres.fields import ArrayField
 from django.db import models
-from django.utils.translation import gettext as _
+from django.utils.translation import gettext_lazy as _

 from application.models import Application

This change will ensure that the gettext function is used correctly for string interpolation and internationalization purposes in your Django application.

Expand Down
Loading