Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Model get in migration file
fix: Embedding model setting

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 30, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhanweizhang7 zhanweizhang7 merged commit 775aa91 into v2 Oct 30, 2025
4 of 5 checks passed
@zhanweizhang7 zhanweizhang7 deleted the pr@v2@fix_embedding_model_in_system branch October 30, 2025 06:33
['TTS','LLM','IMAGE','TTI','STT','EMBEDDING'].includes(row.model_type) &&
permissionPrecise.paramSetting()
"
>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line of code you've provided has a minor issue with variable naming. You use 'EMBEDDING' but then check for 'model_type === 'E'' which does not match the variable name used in row.model_type. It should be:

                   <el-dropdown-item
                    @click.stop="openParamSetting(row)"
                     v-if="
-                      ['TTS','LLM','IMAGE','TTI','STT','RERANKER'].includes(row.model_type) &&
+                      ['TTS','LLM','IMAGE','TTI','STT','EMBEDDING'].includes(row.model_type) &&
                       permissionPrecise.paramSetting()
                     "
                   >

Additionally, ensure that permissionPrecise is properly initialized and callable within the scope where this component is using it to avoid any potential runtime errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants