Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Migration

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 30, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

('knowledge', '0001_initial'),
]

operations = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there appears to be an error in this migration file. The dependencies list should not include apps that are not required by the models being modified. Specifically:

  1. There is no system_manage.models mentioned.
  2. Although 'tool' app was previously added, it seems like an unnecessary dependency.

The correct line should be without the entries for 'tools' and 'knowledge':

dependencies = [
    ('system_manage', '0002_refresh_collation_reindex'),
]

Also, ensure that none of these dependencies have already been satisfied earlier in the migrations history (in previous versions), or you might cause circular references if they depend on each other.

@zhanweizhang7 zhanweizhang7 merged commit d9bda96 into v2 Oct 30, 2025
4 of 5 checks passed
@zhanweizhang7 zhanweizhang7 deleted the pr@v2@fix_migration branch October 30, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants