Skip to content

fix: The maximum limit for application dialogue has been modified to 10000000 times #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix: The maximum limit for application dialogue has been modified to 10000000 times #4302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/serializers/application_access_token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class AccessTokenEditSerializer(serializers.Serializer):
access_token_reset = serializers.BooleanField(required=False,
label=_("Reset Token"))
is_active = serializers.BooleanField(required=False, label=_("Is it enabled"))
access_num = serializers.IntegerField(required=False, max_value=10000,
access_num = serializers.IntegerField(required=False, max_value=10000000,
min_value=0,
label=_("Number of visits"))
white_active = serializers.BooleanField(required=False,
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The access_num field's max_value is set to 1,000, which may not be the intended constraint. Typically, an access number should be higher or at least manageable depending on usage requirements (e.g., one million accesses per token). Here's a revised version:

  1. Increase Maximum Value: The maximum value can be increased based on expected usage.
  2. Documentation Update: A note about this adjustment should be included in the Django REST Framework documentation.
class AccessTokenEditSerializer(serializers.Serializer):
    """
        A serializer for editing access tokens with additional fields such as reset, activation status, and visit count.
    """

    # ...

Revision Summary: Increase max_value from 1,000 to a more suitable upper bound like 10,000,000 or even higher if needed. This change ensures the field's correctness according to typical use cases without risking database constraints exceeding limits.

Expand Down
2 changes: 1 addition & 1 deletion ui/src/views/application-overview/xpack-component/XPackLimitDrawer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
v-model="form.access_num"
:min="0"
:step="1"
:max="10000"
:max="10000000"
:value-on-clear="0"
controls-position="right"
style="width: 268px"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the provided code snippet, there is one change to optimize performance and reduce user input errors:

-          :max="10000"
+          :max="10000000"

Modification Explanation: The max prop from 10,000 to 10,000,000 increases the range of values that users can enter into the input field. This allows for more flexible data entry without exceeding typical limits (e.g., for numerical IDs). Adjusting this value ensures that potential future requirements or constraints are considered.

This change does not introduce irregularities or significant issues, but it enhances the flexibility of the form component by accommodating larger inputs, which could be beneficial depending on specific use cases.

Expand Down
Loading