Full Review #54
Open
Full Review #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tables and navs have been reviewed.
uguryuruk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alerts, badges, button groups, buttons, grid, jumbotron, pagination, tables and navs have been reviewed.
Firstly, thank you @thekalinga @Mershl @nickylogan for that package which helped me learn better not only bootstrap but also CSS and HTML.
I have made some reordering, some little fixes, class suggestions and added some classes, accessibility features and stop-points.
I have changed class suggestions because most of them were not working in VS code-like btn-$suggestion. I have changed them to (${2:btn-primary|btn-secondary|btn-success|btn-danger|btn-warning|btn-info|btn-light|btn-dark|btn-link})
Sometimes I have read the reference and added some features.
If you like these or have any feedback, I will continue with the other components. This is the way I appreciate.