feat: allow random_seed and node_redshifts to be set in TOML profiles#618
Open
steven-murray wants to merge 1 commit intomainfrom
Open
feat: allow random_seed and node_redshifts to be set in TOML profiles#618steven-murray wants to merge 1 commit intomainfrom
steven-murray wants to merge 1 commit intomainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
Author
|
@DanielaBreitman you might be interested in this too |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the reading/writing of TOML "template" files to allow
random_seedandnode_redshiftsto be written there.Fixes #559
In particular, this allows for much easier loading of cached coeval boxes after running a simulation. E.g. in the run script you might have...
Now, after running that very large simulation, you would like to read some boxes with the nifty
RunCachetool in a separate script. Before this PR you must do:And hope that you kept the random seed and node redshifts in sync between the two scripts.
Now you can just do:
I made it so that by default if
mode='full'inwrite_template()the full information is written (including random seed and node redshifts). However, ifmode="minimal"then these are not written. A minimal template is meant to be more like a "physical model" (like our built in templates) which doesn't try to specify what the exact random seed is.