Yasser branch #12
Open
Yasser branch #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasoOppelt
requested changes
Jan 21, 2025
templates/Customer/new.html.twig
Outdated
| <span class="input-group-text"> | ||
| <i class="bi bi-envelope"></i> | ||
| </span> | ||
| {{ form_widget(form.email, { attr: { class: 'form-control' } }) }} |
There was a problem hiding this comment.
Errors from backend are not showing, you can place form_errors here
| </div> | ||
| <hr class="my-4"> | ||
|
|
||
| {#Home Address Section#} |
There was a problem hiding this comment.
Duplicit code blocks. You can create new component and include it here 3 times with different parameters
templates/Customer/show.html.twig
Outdated
| {% endif %} | ||
| <div class="row mb-4 mt-5 justify-content-center"> | ||
| <div class="col-4 text-center d-grid gap-2"> | ||
| <a href="/" class="btn btn-secondary">Back</a> |
There was a problem hiding this comment.
use path function for links
| @@ -0,0 +1,71 @@ | |||
| <script lang="ts"> | |||
| export let addressFields; | |||
| @@ -0,0 +1,66 @@ | |||
| <script lang="ts"> | |||
| export let basicFields; | |||
There was a problem hiding this comment.
types will help you with autocompletion and with maintaining code
|
|
||
| let customer = undefined as undefined | CustomerType; | ||
|
|
||
| const navTabs = [ |
| </div> | ||
| </div> | ||
|
|
||
| {#if customer.addressHome} |
There was a problem hiding this comment.
duplicit blocks of code. Use component instead
| let billingCountryRequired = false; | ||
|
|
||
| //update required status based on other fields | ||
| $: homeCountryRequired = |
| }; | ||
|
|
||
| //prefill address fields if they exist | ||
| if (customer.addressHome) { |
| </div> | ||
|
|
||
| <!-- Home Address --> | ||
| <div |
There was a problem hiding this comment.
can be loaded automaticaly based on navTabs variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.