perf(wallet): checkpoint sync persistence - #32
Conversation
|
Post-fix Testnet verification completed with the compiled branch binary. Matched 20-second
Each controlled run reached its timeout normally. A continued branch replay then completed from block 16,800 to live target 42,209 with exit 0: 25,409 blocks and exactly 255 persistent writes ( Also passed locally: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec95423962
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9621778ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b252ca70e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Upstream logos-blockchain#632 is the minimal happy-path optimization: checkpoint every 100 blocks and flush only on successful completion. This PR includes that behavior plus failure-path durability and atomicity safeguards: it flushes partial progress on polling/validation errors and validates a whole block before applying any privacy-state mutation. That makes this PR materially safer under retries/restarts, not just a different implementation style. |
2088fb4 to
2fa62b1
Compare
|
Rebased onto merged Post-rebase local verification passed:
The branch was force-updated to |
|
All required checks are green and review-thread audit shows no unresolved comments. Promoting for merge. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Root cause
WalletCore::sync_to_blocksynchronously serialized and fsynced the complete storage snapshot after every streamed block.Validation
cargo +nightly fmt --all -- --checkcargo test -p wallet --libcargo clippy -p wallet --all-targets --all-features -- -D warningsCloses #31