Skip to content

fix: parser output quality improvements#12

Merged
3rdflr merged 1 commit intomainfrom
feat/parser-improvements
Feb 23, 2026
Merged

fix: parser output quality improvements#12
3rdflr merged 1 commit intomainfrom
feat/parser-improvements

Conversation

@3rdflr
Copy link
Owner

@3rdflr 3rdflr commented Feb 23, 2026

Summary

  • ❌ 제거됨 오탐 수정: attributeLinesToSymbols에서 context 라인을 추적해 심볼이 파일에 남아있으면 removed 대신 modified로 분류 (GachaBoardPage 등 리팩토링 케이스 해결)
  • useEffect 중복 제거: added/removed 양쪽에 같은 신호가 나오면 한 번만 표시 (deps 변경 → ~ useEffect deps 변경)
  • 헤더/이모지 축소: PR 헤더에서 📖 제거, 파일 헤더 ## 📄 \file`## `file``, 메타 정보 한 줄로 압축 (모바일에서 두 줄 방지)
  • 잘린 코드 라인 필터링: isSyntacticallyIncomplete로 괄호가 열린 채 끝나는 mid-expression 라인을 buildBehaviorSummary 전에 제거

Test plan

…ted lines

- attributeLinesToSymbols: track context lines per symbol; if a symbol
  has context lines it still exists in the file → classify as modified
  instead of removed (fixes GachaBoardPage false-removed case)
- generateSymbolSections: deduplicate behavioral signals that appear in
  both added and removed sides (e.g. useEffect deps change shows once)
- isSyntacticallyIncomplete: filter out mid-expression fragments before
  buildBehaviorSummary so truncated lines like 'data.image_url) ...' are
  never surfaced
- cli.ts: remove emoji from PR/file headers, compress meta line to one
  row to avoid two-line wrapping on mobile
@github-actions
Copy link
Contributor

📖 PR #12 — fix: parser output quality improvements

Repository: 3rdflr/github-mobile-reader
Commit: f3f9f2d
변경된 JS/TS 파일: 2개


📄 src/cli.ts

✏️ processPR (Function) — 변경됨


📄 src/parser.ts

getOrCreate (Function) — 새로 추가
변수: symbolMap, contextLines

  • (cond) !contextLines.has(name)) contextLines.set(name, []

attributeLinesToSymbols (Function) — 새로 추가

  • getOrCreate()

extractPropsChanges (Function) — 새로 추가
변수: namePattern

isSyntacticallyIncomplete (Function) — 새로 추가
파라미터+ line

✏️ buildBehaviorSummary (Function) — 변경됨
변수: parens

generateSymbolSections (Function) — 제거됨
변수: normalized

  • buildBehaviorSummary(sym.addedLines)

deduped (Function) — 새로 추가
변수: addedBehavior, removedBehavior

changedOnly (Function) — 새로 추가
변수: core, removedCore

pureRemoved (Function) — 새로 추가
변수: addedCore


🛠 Auto-generated by github-mobile-reader. Do not edit manually.

@3rdflr 3rdflr merged commit 312b9b7 into main Feb 23, 2026
1 check passed
@3rdflr 3rdflr deleted the feat/parser-improvements branch February 23, 2026 06:44
3rdflr added a commit that referenced this pull request Feb 24, 2026
…ted lines (#12)

- attributeLinesToSymbols: track context lines per symbol; if a symbol
  has context lines it still exists in the file → classify as modified
  instead of removed (fixes GachaBoardPage false-removed case)
- generateSymbolSections: deduplicate behavioral signals that appear in
  both added and removed sides (e.g. useEffect deps change shows once)
- isSyntacticallyIncomplete: filter out mid-expression fragments before
  buildBehaviorSummary so truncated lines like 'data.image_url) ...' are
  never surfaced
- cli.ts: remove emoji from PR/file headers, compress meta line to one
  row to avoid two-line wrapping on mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant