Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Waku v0.22 community adapter useRouter update #963

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

rmarscher
Copy link
Contributor

useRouter is no longer unstable in Waku since v0.22.

useRouter is no longer unstable in Waku since v0.22.
Copy link

vercel bot commented Apr 4, 2025

@rmarscher is attempting to deploy a commit to the 47ng Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe we could add a comment about how to import it in older versions?

Since community adapters don't have SemVer ranges enforced in a package.json, I'm not sure what's the best strategy to deliver them over time:

  • Always target latest
  • Have a semver range added as a comment at the top of the file
  • Other ideas?

Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 5:27am

@franky47 franky47 added the adapters/community Custom community-provided adapters label Apr 5, 2025
@franky47 franky47 added this to the 🪵 Backlog milestone Apr 5, 2025
@rmarscher rmarscher changed the title chore(docs): Waku community adapter useRouter update chore(docs): Waku v0.22 community adapter useRouter update Apr 7, 2025
@rmarscher
Copy link
Contributor Author

Thanks! I added a comment and edited the title of this PR to include that waku version number. I think most people currently running Waku are following pretty closely as the API has been unstable pre-1.0. Targeting the latest and letting people look at the community adapter git history is probably fine. I don't expect it to change moving forward so this shouldn't be too much of an issue.

@franky47 franky47 merged commit e2b2d37 into 47ng:next Apr 7, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters/community Custom community-provided adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants