Feature #41 | Update related resources identifier and relationship types for IGSN and Remove Deposit Agreement

[gabrielakuhn]

Summary

Related resources update

For the IGSN service, we would also like a few updates in the ‘Related resources’ section:

Identifier types are: IGSN DOI, Other DOI, URL.
We need to change it for: IGSN, DOI, URL.

Relationship types are currently:

• Is part of
• Has part
• Is derived from
• Is source of

We need to add relationship types:

• Is referenced by
• References
• Is cited by
• Cites
• Is described by
• Describes

Remove Deposit Agreement

Also: The Deposit Agreement does not yet cover physical samples. It will be replaced
by the Terms of Service later, thus we need to remove Deposit Agreement for now.

Changes

• src/djehuty/web/resources/static/js/edit-physical-sample.js: Rename identifier types
  and add additional relationship types for related resource and remove the Deposit
  Agreement form field and error handling.
• src/djehuty/web/wsgi.py: Accept the additional related resource relationship types and
  stop requiring agreement to the Deposit Agreement when submitting a physical sample for review.
• src/djehuty/web/resources/html_templates/depositor/edit-physical-sample.html:
  Remove the Deposit Agreement checkbox from the terms section.
• src/djehuty/web/wsgi.py:

Approval Checklist

• I agree to follow Djehuty's code of conduct.
• I have read and I have follow the code contribution workflow.
• Code style and conventions were respected.
• Documentation has been updated where needed (README, docs, or examples).
• Review approved by at least one maintainer.
• Merge readiness (PR is squashed into a single commit and follows the commit template).

Issue Reference
Part of #41

Screenshots

Related resources update

After

Remove Deposit Agreement

Before

After

Notes

Branch forked from wip-feat-41-igsn-dates-format

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.32%. Comparing base (ebb33d1) to head (f695c96).

Files with missing lines	Patch %	Lines
src/djehuty/web/wsgi.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                       @@
##           wip-feat-41-igsn-dates-format     #200   +/-   ##
==============================================================
  Coverage                          16.32%   16.32%           
==============================================================
  Files                                 21       21           
  Lines                              11460    11458    -2     
  Branches                            2250     2249    -1     
==============================================================
  Hits                                1871     1871           
+ Misses                              9398     9396    -2     
  Partials                             191      191           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[641e16]

Changes look good; the Deposit Agreement removal is clean. All six new relationship types are valid DataCite relationType values and pass through the XML formatter unchanged.

One question:

Do IGSN and DOI need to differ in the exported metadata? The dropdown now offers "IGSN" and "DOI" as separate choices, but xml_formatter.py:477 treats IGSNDOI and OtherDOI identically; both go through normalize_doi and both emit relatedIdentifierType="DOI". So the two options produce byte-identical DataCite output; only
the stored type_id differs, and nothing reads it. Since this is specifically for the IGSN service, should IGSNDOI emit relatedIdentifierType="IGSN" (a valid DataCite value)?

Unrelated, and I don't think it's caused by this PR: while testing the new relationship types locally I couldn't get any related resource to appear after pressing ADD. Confirmed against a local just dev instance: the POST succeeds (the follow-up GET only fires from its success callback) and that GET comes back with an empty list, so the row is rebuilt blank and nothing is listed.