Feature #41 | Support date ranges for physical samples. - #219
Open
gabrielakuhn wants to merge 2 commits into
Open
Feature #41 | Support date ranges for physical samples.#219gabrielakuhn wants to merge 2 commits into
gabrielakuhn wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## wip-feat-41-igsn-related-resources #219 +/- ##
======================================================================
- Coverage 16.32% 16.30% -0.03%
======================================================================
Files 21 21
Lines 11458 11504 +46
Branches 2249 2261 +12
======================================================================
+ Hits 1871 1876 +5
- Misses 9396 9437 +41
Partials 191 191 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
* src/djehuty/web/validator.py: Add partial_date_range_value, which returns the start and the end of a range. * src/djehuty/web/database.py: Store the end as a separate date_end, so each end keeps the datatype. * src/djehuty/web/resources/sparql_templates/physical_sample_dates.sparql: Read date_end with OPTIONAL, because only ranges carry one. * src/djehuty/web/xml_formatter.py: Join dates range with a slash for DataCite. * src/djehuty/utils/convenience.py: Add convenience for day_first_date and date_or_range to render a date. * src/djehuty/web/wsgi.py: Render date range for physical_sample. * src/djehuty/web/resources/html_templates/depositor/edit-physical-sample.html: Add a Range tab to the date form. * src/djehuty/web/resources/static/js/edit-physical-sample.js: Handle range tab.
…mple * src/djehuty/web/resources/html_templates/depositor/edit-physical-sample.html: Start and end of a range on one line. * src/djehuty/web/resources/static/js/edit-physical-sample.js: Handle every format from a single input.
gabrielakuhn
force-pushed
the
wip-feat-41-igsn-date-range
branch
from
July 31, 2026 16:26
bdc0cbf to
7222b10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the options of Date range in the "Dates" of physical sample.
Now only ranges carry an extra triple
date_end. It is read as OPTIONALbecause only ranges dates carry one. This is written like in this way to
keep
datetypefor dates.Changes
the start and the end of a range.
keeps the datatype.
Read date_end with OPTIONAL, because only ranges carry one.
to render a date.
Add a Range tab to the date form.
Approval Checklist
Issue Reference
Part of #41
Screenshots
After

Notes
Forked from wip-feat-41-igsn-related-resources