fix: Consistent cite button label - #277
Open
kikisprdx wants to merge 2 commits into
Open
Conversation
* src/djehuty/web/resources/static/js/utils.js: Keep the label at "Cite" instead of switching to "Citation" when open. signed-off-by: kikis <kikispcmr@gmail.com>
* tests/e2e/tests/test_citation.py: Add test to ensure that citation button text remains as "cite". Signed-off-by: Kikis <kikispcmr@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 18.06% 18.06%
=======================================
Files 21 21
Lines 10507 10507
Branches 2038 2038
=======================================
Hits 1898 1898
Misses 8417 8417
Partials 192 192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the "Cite" button as is when opening/closing the citation tab. Previously, text would change to "Citation" but would never revert. After a short discussion, we decided that the text change is unnecessary.
Changes
toggle_cite_collectno longer swaps the cite button's text to "Citation" when opening the panel.test_cite_button_label_stays_citeasserting the button text stays "Cite" across closed, opened, and re-closed.Approval Checklist
Issue Reference (optional - PRs may not be associated with an issue)
Closes #213
Screenshots (optional)
Notes (optional)
Additional context, caveats, or follow-up tasks.