Use TreeView in InstructionSelector #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Jan 10, 2025
newIDE/app/src/EventsSheet/InstructionEditor/InstructionOrObjectSelector.js
Show resolved
Hide resolved
newIDE/app/src/EventsSheet/InstructionEditor/InstructionOrObjectSelector.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/EventsSheet/InstructionEditor/InstructionOrObjectSelector.js
Outdated
Show resolved
Hide resolved
|
|
||
| getHtmlId(index: number): ?string { | ||
| // TODO: Make sure it keeps the in-app-tutorial work. | ||
| return `object-item-${index}`; |
There was a problem hiding this comment.
should this be object-folder-index? is the todo still to do ?
There was a problem hiding this comment.
I cleaned everything, we don't need those object-item-... anymore
| @@ -2217,39 +2216,6 @@ storiesOf('SearchPanel', module) | |||
| /> | |||
| )); | |||
|
|
|||
| storiesOf('InstructionSelector', module) | |||
There was a problem hiding this comment.
do we have a story for the InstructionSelector elsewhere? so we can check the ReadOnlyTreeView
There was a problem hiding this comment.
I removed the InstructionSelector component because it was not used anywhere. I can try to add a story for the InstructionOrObjectSelector
There was a problem hiding this comment.
Actually, there is already one!
… groups container
AlexandreSi
changed the title
4ian
reviewed
Jan 14, 2025
| game. | ||
| </Trans> | ||
| </DismissableAlertMessage> | ||
| {/* TODO: Should the "Only global objects..." mention should be kept since |
There was a problem hiding this comment.
Yes, let's remove mention to global objects.
AlexandreSi
force-pushed
the
instruction-object-tree-view
branch
from
31675c5 to
ac749bb
Compare
AlexandreSi
force-pushed
the
instruction-object-tree-view
branch
from
ac749bb to
dda8a8c
Compare
AlexandreSi
force-pushed
the
instruction-object-tree-view
branch
from
91ce1c5 to
d7c6915
Compare
4ian
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
TODO: