RFD-0004: Diagram with regular flow and migration flow. #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cjus
reviewed
May 2, 2024
| state: discussion | ||
| --- | ||
|
|
||
| ## Objective |
There was a problem hiding this comment.
Perhaps this proposal is missing a WHY? Why is this important - other than the potential to unify flows?
| We can probably simplify the implementation | ||
| (at the cost of worse performance, as noted above). | ||
|
|
||
| ### User Impact |
There was a problem hiding this comment.
How does this change the /flows folder structure & file naming convention, if any?
Is there an example flow.ts for this new approach? I think I remember an import mapping PR and it looked clean. That could be a good way to show why this is easier to understand for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is the mermaid diagram worth it? IDK