WIP egress type validation #1989
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| res.setHeader("Content-Type", "application/json"); | ||
| res.end(JSON.stringify(response)); |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we need to ensure that stack trace information is not exposed to the client, even in a development environment. Instead, we should log the stack trace on the server and send a generic error message to the client. This can be achieved by modifying the error handling code to exclude the stack trace from the response and only include a generic error message.
Suggested changeset
1
packages/ts-moose-lib/src/consumption-apis/runner.ts
| @@ -310,3 +310,3 @@ | ||
| details: | ||
| process.env.NODE_ENV === "development" ? error : undefined, | ||
| process.env.NODE_ENV === "development" ? error.message : undefined, | ||
| }, | ||
| @@ -319,2 +319,3 @@ | ||
| logToConsole(`apiHandler: Response: ${JSON.stringify(response)}`); | ||
| logToConsole(`Stack trace: ${error instanceof Error ? error.stack : String(error)}`); | ||
| return; |
Copilot is powered by AI and may make mistakes. Always verify output.
…eUsers?limit=1'
{"success":true,"data":[{"date":"2024-04-02","dailyActiveUsers":"1"}]}%
➜ test-typia git:(main) ✗ curl 'localhost:4000/consumption/dailyActiveUsers?limit=asdf'
{"success":false,"error":{"code":"INTERNAL_ERROR","message":"LIMIT numeric constant expression is not representable as UInt64. "}}% ➜ test-typia git:(main) ✗
…checking-for-consumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.