moose cleanup #2053
Open
moose cleanup #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
callicles
requested changes
Feb 21, 2025
| @@ -58,12 +58,8 @@ pub enum Commands { | |||
| Dev {}, | |||
| /// Start a remote environment for use in cloud deployments | |||
| Prod {}, | |||
| /// Generates missing migration files | |||
| /// Generates sdk for your data models | |||
There was a problem hiding this comment.
This is also used to generate the hash function - so probably not accurate helper
| }; | ||
| Ok(()) | ||
| } | ||
|
|
||
| pub async fn resume_initial_data_load( |
There was a problem hiding this comment.
Shouldn't this be deleted as well?
| let available_topics: HashSet<String, RandomState> = | ||
| HashSet::from_iter(fetch_topics(&kafka_config).await?); | ||
|
|
||
| // Spawn sync for the current and old models |
There was a problem hiding this comment.
That feels like it should not get deleted
|
Also a callout for something that needs to be tested - with DCM we were using version with naming DMs with removing DCM we probably should remove the naming versioning? |
|
or we could keep it - not sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump-versionandgenerate migrations