Cjus/improve redis client #2054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* updated python starter code * streaming docs * first draft scripts * ingest * fix imports * fix python/ts distinctions * remove params * clean up * trigger via moose API make python only * workflows cron update * pydantic * quickstart fix * starter code for ts and python * update e2e tests * data passing ts, fix python MV * chris ingest feedback * chris feedback + workflow ingest * workflow ts syntax fix --------- Co-authored-by: Jonathan Widjaja <[email protected]>
|
Did you rebase? it looks like some commits in here are duplicate to what's in main? |
|
Would be nice if you could clean that up - it makes the diff dirty and harder to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and fixes to the Redis client in the
framework-cliapplication. The most important changes include the addition of a connection manager, a connection monitor, and various improvements to error handling and logging.Enhancements to Redis Client:
connection-managerfeature toredisdependency inCargo.tomlto utilize the connection manager for better connection handling.ConnectionManagerfor managing Redis connections, replacing the previous manual connection handling. [1] [2]Improvements to Error Handling and Logging:
<RedisClient>for better log filtering and readability. [1] [2] [3] [4]Codebase Simplification:
setup_redis_clientfunction to spawn the connection monitor task. [1] [2]RedisClientstruct to include anAtomicBoolfor tracking connection state. [1] [2]Dependency Updates:
futures::FutureExtto handle future extensions andredis::aio::ConnectionManagerfor managing asynchronous Redis connections.These changes collectively improve the reliability and maintainability of the Redis client by leveraging the connection manager, enhancing error handling, and providing better logging.