-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicolas/514oss 1383 api endpoint to execute the changes #2059
Open
callicles
wants to merge
10
commits into
main
Choose a base branch
from
nicolas/514oss-1383-api-endpoint-to-execute-the-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nicolas/514oss 1383 api endpoint to execute the changes #2059
callicles
wants to merge
10
commits into
main
from
nicolas/514oss-1383-api-endpoint-to-execute-the-changes
+636
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tg339
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://cap.link/rn36znv09hq3v83
This pull request includes several changes to improve the infrastructure reality check functionality and add new features to the data model configuration. The most important changes include modifying the
InfraDiscrepancies
structure, adding debug logging for table differences, and updating theStorageConfig
andDataModel
structures to include an optional name field.Infrastructure Reality Check Improvements:
apps/framework-cli/src/framework/core/infra_reality_checker.rs
: Changedunmapped_tables
fromVec<String>
toVec<Table>
in theInfraDiscrepancies
struct and updated the logic to reflect this change. [1] [2]apps/framework-cli/src/framework/core/infra_reality_checker.rs
: Updated test cases to check forTable
objects instead ofString
values.Debug Logging Enhancements:
apps/framework-cli/src/framework/core/infrastructure_map.rs
: Added debug logging to identify differences between tables when comparing infrastructure maps.Data Model Configuration Enhancements:
apps/framework-cli/src/framework/data_model/config.rs
: Added an optionalname
field to theStorageConfig
struct. [1] [2]apps/framework-cli/src/framework/data_model/model.rs
: Updated theto_table
method in theDataModel
struct to use the optionalname
field if provided.packages/ts-moose-lib/src/index.ts
: Added an optionalname
field to theDataModelConfig
type.