Story/000213/fix backlogitem edit issue (#214)

* implemented validation for status * bump ver * fix backlog item status update issue Co-authored-by: Kevin <[email protected]>
51ngul4r1ty · Dec 6, 2020 · 2bd336b · 2bd336b
1 parent 4d399cc
commit 2bd336b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "atoll",
-  "version": "0.26.0",
+  "version": "0.26.1",
   "author": {
     "name": "Kevin Berry",
     "email": "[email protected]"
@@ -57,7 +57,7 @@
     "setup": "ts-node ./scripts/setup.ts"
   },
   "dependencies": {
-    "@atoll/shared": "0.26.0",
+    "@atoll/shared": "0.26.1",
     "@flopflip/memory-adapter": "1.6.0",
     "@flopflip/react-broadcast": "10.1.11",
     "axios": "0.19.2",

diff --git a/src/server/api/handlers/backlogItems.ts b/src/server/api/handlers/backlogItems.ts
@@ -5,7 +5,7 @@ import * as HttpStatus from "http-status-codes";
 import { CreateOptions, Transaction } from "sequelize";
 
 // libraries
-import { ApiBacklogItem, ApiBacklogItemRank } from "@atoll/shared";
+import { getValidStatuses, isValidStatus, ApiBacklogItem, ApiBacklogItemRank } from "@atoll/shared";
 
 // data access
 import {
@@ -308,6 +308,13 @@ export const backlogItemPutHandler = async (req: Request, res: Response) => {
         );
         return;
     }
+    if (!isValidStatus(req.body.status)) {
+        respondWithFailedValidation(
+            res,
+            `Status "${req.body.status}" is not a valid value - it should be one of the following: ${getValidStatuses().join(", ")}`
+        );
+        return;
+    }
     try {
         const backlogItem = await BacklogItemModel.findOne({
             where: { id: bodyItemId }