Skip to content

fix unquoted and half-quoted tag attrib parsing #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tacc-tacc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix unquoted and half-quoted tag attrib parsing #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions wikitextparser/_spans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@
# https://www.w3.org/TR/html5/syntax.html#syntax-attributes
ATTR_NAME = rb'(?<attr_name>[^' + SPACE_CHARS + CONTROL_CHARS + rb'"\'>/=]++)'
EQ_WS = rb'[=\1][' + SPACE_CHARS + rb']*+'
UNQUOTED_ATTR_VAL = rb'(?<attr_value>[^' + SPACE_CHARS + rb'"\'=<>`]++)'
QUOTED_ATTR_VAL = rb'(?<quote>[\'"])(?<attr_value>.*?)(?P=quote)'
UNQUOTED_ATTR_VAL = rb'[\'"]?(?<attr_value>[^' + SPACE_CHARS + rb'"\'=<>`/]++)'
QUOTED_ATTR_VAL = rb'(?<quote>[\'"])(?<attr_value>[^"\'<>]*?)(?P=quote)'
# May include character references, but for now, ignore the fact that they
# cannot contain an ambiguous ampersand.
ATTR_VAL = (
Expand All @@ -164,9 +164,9 @@
+ rb']*+'
+ EQ_WS
+ rb'(?>'
+ UNQUOTED_ATTR_VAL
+ rb'|'
+ QUOTED_ATTR_VAL
+ rb'|'
+ UNQUOTED_ATTR_VAL
+ rb')'
+ rb'|(?<attr_value>)' # empty attribute
+ rb')'
Expand Down