chore: add with_headers method#245
Closed
b0xtch wants to merge 4 commits into64bit:mainfrom
Closed
Conversation
Owner
|
Thanks for the PR, I'll leave review seperately |
64bit
reviewed
Jul 24, 2024
| api_base: String, | ||
| api_key: Secret<String>, | ||
| #[serde(deserialize_with = "deserialize_header_map")] | ||
| headers: HashMap<String, String>, |
Owner
There was a problem hiding this comment.
Please use native HeaderMap instead of custom conversion with custom deserializer.
64bit
reviewed
Jul 24, 2024
| api_key: std::env::var("OPENAI_API_KEY") | ||
| .unwrap_or_else(|_| "".to_string()) | ||
| .into(), | ||
| headers: HashMap::new(), |
Owner
There was a problem hiding this comment.
nit: since this is platform independent - this and with_headers could be a nice addition to AzureConfig as well for consistency. Not required though.
|
Hey, any raeson this is not merged yet ? |
Owner
|
Thanks for the PR! The latest release has https://docs.rs/async-openai/0.31.0-alpha.7/async_openai/config/struct.OpenAIConfig.html#method.with_header, hence closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support custom headers required for observability applications