fix: remove redundant .to_dict() in list_tasks API#667
Open
lidaye910416 wants to merge 1 commit into
Open
Conversation
TaskManager.list_tasks() already returns serialized dicts, so calling .to_dict() on each item causes AttributeError: 'dict' object has no attribute 'to_dict' Fixes: AttributeError in /api/graph/tasks endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Remove redundant .to_dict() in list_tasks API
Problem
The
/api/graph/tasksendpoint throwsAttributeError: 'dict' object has no attribute 'to_dict'.Root Cause
TaskManager.list_tasks()already returns serialized dicts via.to_dict()at line 172 intask.py:But the API endpoint in
graph.py:562calls.to_dict()again on each item:Fix
Simply return
tasksdirectly since it is already a list of dicts.Testing
curl /api/graph/tasks-> 500 Errorcurl /api/graph/tasks->{"success": true, "data": [], "count": 0}