Skip to content

Citation format fix for non DOI items #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

akhuoa
Copy link
Member

@akhuoa akhuoa commented Jan 17, 2025

Features

  • Add an option, useDOIFormatter (default is true), to choose between citation.doi.org or citation.js to format citations.
  • Style error items with a "reload" button.

image

  • Export get citation method (getCitationById method can be exported)

Related PRs

@alan-wu
Copy link
Member

alan-wu commented Feb 12, 2025

@akhuoa I cannot install some of the new citation packages without using npm install --force, can you double check that for me please?

Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhuoa Can you separate out the style change for error citation class into its own pull request please? I will hold off approving this pull request as citation.js increased the bundle size from ~1050kb to ~1800kb. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants