-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add profile option to always view full names in event view #566
feat: Add profile option to always view full names in event view #566
Conversation
Created migration to add :prefers_full_name to member. Added the option to edit it. Made it change the way names are displayed by event_role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty solid! I have some thoughts on the naming choices but implementation lgtm!
app/models/event_role.rb
Outdated
if options[:use_both_names] | ||
"#{member.display_name} (#{member.fullname})" | ||
else | ||
member.display_name | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this particular nesting is the best option -- IMO use_both_names
should take precedence when true and not be conditional on use_display_name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the function so it doesn't take options so this should not be an issue anymore
Also, this PR does not currently change emails (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO CLOSE
db/migrate/20250128235438_add_fulltext_index_to_events_and_event_dates.rb
Outdated
Show resolved
Hide resolved
Thanks! Note that we need to deal with #576 (revert or fix) before I can deploy it. |
Created migration to add :prefers_full_name to member. Added the option to edit it. Made it change the way names are displayed by event_role.