Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add profile option to always view full names in event view #566

Conversation

tomas-goncalves
Copy link
Contributor

Created migration to add :prefers_full_name to member. Added the option to edit it. Made it change the way names are displayed by event_role.

Created migration to add :prefers_full_name to member. Added the option to edit it. Made it change the way names are displayed by event_role.
Copy link
Contributor

@NoRePercussions NoRePercussions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty solid! I have some thoughts on the naming choices but implementation lgtm!

Comment on lines 118 to 122
if options[:use_both_names]
"#{member.display_name} (#{member.fullname})"
else
member.display_name
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this particular nesting is the best option -- IMO use_both_names should take precedence when true and not be conditional on use_display_name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the function so it doesn't take options so this should not be an issue anymore

@NoRePercussions
Copy link
Contributor

Also, this PR does not currently change emails (e.g. app/views/member_mailer/comment.html.erb) which are hardcoded to tracker nicknames.

Copy link
Contributor

@NoRePercussions NoRePercussions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DaAwesomeP DaAwesomeP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO CLOSE

@DaAwesomeP DaAwesomeP merged commit c94f552 into ABTech:master Feb 5, 2025
@DaAwesomeP
Copy link
Member

Thanks! Note that we need to deal with #576 (revert or fix) before I can deploy it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants