Skip to content

add missing ServerSaveFailed messages for vendor transactions #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LtRipley36706 merged 1 commit into from
Jun 22, 2025
Merged

add missing ServerSaveFailed messages for vendor transactions #4317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Source/ACE.Server/WorldObjects/Player_Commerce.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@ public void HandleActionBuyItem(uint vendorGuid, List<ItemProfile> items)
{
if (IsBusy)
{
Session.Network.EnqueueSend(new GameEventInventoryServerSaveFailed(Session, Guid.Full));
SendUseDoneEvent(WeenieError.YoureTooBusy);
return;
}

if (IsTrading)
{
Session.Network.EnqueueSend(new GameEventInventoryServerSaveFailed(Session, Guid.Full));
SendUseDoneEvent(WeenieError.CantDoThatTradeInProgress);
return;
}
Expand All @@ -37,12 +39,14 @@ public void HandleActionBuyItem(uint vendorGuid, List<ItemProfile> items)

if (vendor == null)
{
Session.Network.EnqueueSend(new GameEventInventoryServerSaveFailed(Session, Guid.Full));
SendUseDoneEvent(WeenieError.NoObject);
return;
}

// if this succeeds, it automatically calls player.FinalizeBuyTransaction()
vendor.BuyItems_ValidateTransaction(items, this);
if (!vendor.BuyItems_ValidateTransaction(items, this))
Session.Network.EnqueueSend(new GameEventInventoryServerSaveFailed(Session, Guid.Full));

SendUseDoneEvent();
}
Expand Down Expand Up @@ -123,6 +127,7 @@ public void HandleActionSellItem(uint vendorGuid, List<ItemProfile> itemProfiles
{
if (IsBusy)
{
Session.Network.EnqueueSend(new GameEventInventoryServerSaveFailed(Session, Guid.Full));
SendUseDoneEvent(WeenieError.YoureTooBusy);
return;
}
Expand All @@ -131,6 +136,7 @@ public void HandleActionSellItem(uint vendorGuid, List<ItemProfile> itemProfiles

if (vendor == null)
{
Session.Network.EnqueueSend(new GameEventInventoryServerSaveFailed(Session, Guid.Full));
SendUseDoneEvent(WeenieError.NoObject);
return;
}
Expand Down