Skip to content

style: clean clippy lints in did-stellar-registry#64

Merged
aguilar1x merged 1 commit into
devfrom
fix/registry-clippy
Jun 16, 2026
Merged

style: clean clippy lints in did-stellar-registry#64
aguilar1x merged 1 commit into
devfrom
fix/registry-clippy

Conversation

@aguilar1x

@aguilar1x aguilar1x commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Clears the pre-existing clippy debt in did-stellar-registry so the crate passes clippy -D warnings. No behavior change — purely lint fixes (mostly applied via cargo clippy --fix).

  • manual_range_contains: key-count bound check rewritten with RangeInclusive::contains.
  • len_zero: len() == 0is_empty() in service validation.
  • bool_assert_comparison: assert_eq!(x, true/false)assert!(x) / assert!(!x) in tests.
  • manual_str_repeat / manual_repeat_n: long-string test builders → str::repeat.
  • needless_borrow: dropped a redundant &.
  • duplicated_attributes: removed the redundant inner #![cfg(test)] (the module is already #[cfg(test)]-gated in lib.rs).

@almanax-ai

almanax-ai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Plan expired

Your subscription has expired. Please renew your subscription to continue using CI/CD integration and other features.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aguilar1x, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 51 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f22970be-f518-4cf0-9f0c-fd47e62649c1

📥 Commits

Reviewing files that changed from the base of the PR and between 872d942 and 3285e37.

📒 Files selected for processing (2)
  • contracts/did-stellar-registry/src/contract.rs
  • contracts/did-stellar-registry/src/test.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/registry-clippy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aguilar1x aguilar1x self-assigned this Jun 16, 2026
@aguilar1x aguilar1x merged commit 7083ea5 into dev Jun 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant