fix(did): enable mainnet DID registration#132
Conversation
…stration The published @acta-team/did-stellar@0.1.0 ships an empty mainnet registry default, so registering a DID on mainnet failed with 'no default registry contract is configured for network mainnet'. Pass registryContractId and rpcUrl explicitly per network (testnet did-stellar-registry v0.1.0, mainnet v0.2.0), overridable via NEXT_PUBLIC_DID_REGISTRY_CONTRACT_ID_* and NEXT_PUBLIC_STELLAR_RPC_URL_*, mirroring how the ACTA API base URL is pinned.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Creating a
did:stellaron mainnet failed with:The published
@acta-team/did-stellar@0.1.0shipped an empty mainnet registry default, and the dApp calledprepareRegisterDidXdrwithout an explicitregistryContractId, so it fell back to that empty default.Fix
Pin the
did-stellar-registrycontract ID and Soroban RPC URL per network in the dApp and pass them explicitly toprepareRegisterDidXdr, the same way the ACTA API base URL is already pinned per network.CB7ATU7SF5...), matches whatdid.acta.buildresolves against.CD6LSWW5...), percontracts-acta/docs/deployments/mainnet.md.Both are overridable via env:
NEXT_PUBLIC_DID_REGISTRY_CONTRACT_ID_TESTNET/_MAINNETNEXT_PUBLIC_STELLAR_RPC_URL_TESTNET/_MAINNETNotes
prepare+ wallet + Soroban RPC).did.acta.buildis only used to resolve; for resolution to work on mainnet the DID service still needsDID_REGISTRY_CONTRACT_ID_MAINNET+STELLAR_RPC_URL_MAINNETset.0.1.1with the mainnet default populated; once0.1.1is published, this explicit pinning still works (it just overrides an already-correct default).