Skip to content

fix(did): enable mainnet DID registration#132

Merged
JosueBrenes merged 1 commit into
mainfrom
fix/mainnet-did-registry
Jun 30, 2026
Merged

fix(did): enable mainnet DID registration#132
JosueBrenes merged 1 commit into
mainfrom
fix/mainnet-did-registry

Conversation

@JosueBrenes

Copy link
Copy Markdown
Contributor

Problem

Creating a did:stellar on mainnet failed with:

no default registry contract is configured for network mainnet; pass options.registryContractId

The published @acta-team/did-stellar@0.1.0 shipped an empty mainnet registry default, and the dApp called prepareRegisterDidXdr without an explicit registryContractId, so it fell back to that empty default.

Fix

Pin the did-stellar-registry contract ID and Soroban RPC URL per network in the dApp and pass them explicitly to prepareRegisterDidXdr, the same way the ACTA API base URL is already pinned per network.

  • testnet: did-stellar-registry v0.1.0 (CB7ATU7SF5...), matches what did.acta.build resolves against.
  • mainnet: did-stellar-registry v0.2.0 (CD6LSWW5...), per contracts-acta/docs/deployments/mainnet.md.

Both are overridable via env:

Variable Purpose
NEXT_PUBLIC_DID_REGISTRY_CONTRACT_ID_TESTNET / _MAINNET registry contract ID
NEXT_PUBLIC_STELLAR_RPC_URL_TESTNET / _MAINNET Soroban RPC URL

Notes

  • Registration is fully client-side (SDK prepare + wallet + Soroban RPC). did.acta.build is only used to resolve; for resolution to work on mainnet the DID service still needs DID_REGISTRY_CONTRACT_ID_MAINNET + STELLAR_RPC_URL_MAINNET set.
  • The SDK was also bumped to 0.1.1 with the mainnet default populated; once 0.1.1 is published, this explicit pinning still works (it just overrides an already-correct default).

…stration

The published @acta-team/did-stellar@0.1.0 ships an empty mainnet registry
default, so registering a DID on mainnet failed with 'no default registry
contract is configured for network mainnet'. Pass registryContractId and
rpcUrl explicitly per network (testnet did-stellar-registry v0.1.0, mainnet
v0.2.0), overridable via NEXT_PUBLIC_DID_REGISTRY_CONTRACT_ID_* and
NEXT_PUBLIC_STELLAR_RPC_URL_*, mirroring how the ACTA API base URL is pinned.
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp Ready Ready Preview, Comment Jun 30, 2026 8:53pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JosueBrenes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a3c033d4-53ef-49b9-9e09-e520599b9183

📥 Commits

Reviewing files that changed from the base of the PR and between 620a374 and d4fe489.

📒 Files selected for processing (2)
  • src/components/modules/did/hooks/useDidStellar.ts
  • src/lib/didStellar.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mainnet-did-registry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JosueBrenes JosueBrenes merged commit d407dc4 into main Jun 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant