Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional bindings to operator controller #55

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

TheFlameFish
Copy link
Contributor

@TheFlameFish TheFlameFish commented Mar 15, 2025

Requested by drive team, specific bindings confirmed by Lucas

TODO:

  • Test on Nautilus(?)

nolanhergert
nolanhergert previously approved these changes Mar 17, 2025
@TheFlameFish TheFlameFish changed the title Add button to disable vision and button to move arm to source Add additional bindings to operator controller Mar 20, 2025
nolanhergert
nolanhergert previously approved these changes Mar 21, 2025
Copy link
Contributor

@nolanhergert nolanhergert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Lucas is ok with these changes (I assume tested yesterday), then I am ok.

Don't forget to let him know that holding for one second isn't working right now.

Also, does backupController.rightStick().onTrue() mean pressing into the stick and clicking the underlying pushbutton? Seems potentially annoying.

@TheFlameFish
Copy link
Contributor Author

Assuming Lucas is ok with these changes (I assume tested yesterday), then I am ok.

Don't forget to let him know that holding for one second isn't working right now.

Also, does backupController.rightStick().onTrue() mean pressing into the stick and clicking the underlying pushbutton? Seems potentially annoying.

The joystick buttons map to Z and C buttons on the Vader 3s

Copy link
Contributor

@nolanhergert nolanhergert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@TheFlameFish TheFlameFish merged commit a7b137b into main Mar 27, 2025
4 checks passed
@TheFlameFish TheFlameFish deleted the operator-control-additions branch March 27, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants