Various QEMU SnapshotModule fixes
#3542
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cannot restore a dirty but unsaved pagepanic in theresetfunction.printlnfor debug logging. In addition, theMapInfotype has a niceDisplayimplementation that is much more readable than theDebugimplementation.resetfunction uses theAllowList/DenyListto determine which pages to zero out on reset, which is incorrect. Instead, thesnapshotfunction can skip saving the pages that should be skipped entirely, because that will cause theresetmethod to ignore them (pages.get_mut(page)will returnNone). However, the pages that should be zeroed (in aZeroList) still need to be recorded during the snapshot stage, but their contents don't need to be read, so we just save the metadata.Checklist
./scripts/precommit.shand addressed all comments