Fix #134: ModuleNotFoundError: No module named 'agents'#144
Open
JiwaniZakir wants to merge 1 commit intoAIDC-AI:mainfrom
Open
Fix #134: ModuleNotFoundError: No module named 'agents'#144JiwaniZakir wants to merge 1 commit intoAIDC-AI:mainfrom
JiwaniZakir wants to merge 1 commit intoAIDC-AI:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134
Defers the
ImportErrorfor the missing/wrongagentspackage from module-load time to call time, preventing ComfyUI from failing to load the entire plugin on startup.In
backend/agent_factory.py, the top-levelraise ImportError(...)inside theexceptblock is replaced with a_AGENTS_AVAILABLE = Falsesentinel. Theset_default_openai_apiandset_tracing_disabledcalls are guarded behindif _AGENTS_AVAILABLE:, andcreate_agent()now raises the actionable error message only when actually invoked. Inbackend/service/debug_agent.py, the bare imports ofagents.items.ItemHelpersandagents.run.Runnerare wrapped in atry/except ImportErrorthat sets both toNone, so the module can be imported without a functioningagentspackage.backend/agent_factory.py:_AGENTS_AVAILABLEsentinel,create_agent()guardbackend/service/debug_agent.py:ItemHelpers,Runnergraceful fallbackVerified by installing only the legacy RL
agentspackage (withoutopenai-agents) and confirming ComfyUI loads the plugin successfully, with the error surfaced only upon invoking the debug workflow feature.This PR was created with AI assistance (Claude). The changes were reviewed by quality gates and a critic model before submission.