Repository navigation
fix(update): restore the browser after switching builds - #397
Merged
Merged
Conversation
(cherry picked from commit aa7a533497a6b524fbd4d7d330ca06b04414e2fb)
# Conflicts: # internal/app/app.go
(cherry picked from commit 4f2af3371bd5ff89721f222462713bc16beed4b2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a one-click update, the browser can stay on the old page if it misses the final progress response. With automatically generated HTTPS certificates, restarting the server also used to change the certificate, so Chrome could reject the request that checks whether the new process is ready.
The update page now starts checking when the server accepts the job. It identifies the replacement by the activation ID and checks the running Git revision when the target is known. The settings page shows the running build revision alongside the checkout revision.
For local HTTPS with
tls_auto_self_sign, the server saves the certificate and private key underdata/tls/and reuses them on restart. The first upgrade from an in-memory certificate creates a new certificate, so Chrome may still show a warning on that transition.Validation
go build ./..., the self-update and authentication Go race tests, and shell syntax checks passed.