Repository navigation
fix(pi): allow explicit store omission for compatible gateways - #401
Merged
Merged
Conversation
Sycun
marked this pull request as ready for review
November 14, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow administrators to omit the optional
storefield for a Chat Completions channel whose gateway rejects it. Pi can otherwise sendstore: falseto unknown endpoints; the settings connection probe does not send this field.This is an explicit per-channel opt-in using the existing request extensions:
For Chat Completions only, this setting disables Pi's automatic storage field and removes the null extension before sending. Unconfigured channels retain Pi's existing behavior; explicit
store: falseandstore: trueremain intact. No endpoint/domain heuristics are added. Claude and Responses adapters retain their existing behavior. Existing local-profile compatibility remains unchanged.Validation:
go test ./internal/multiagent ./internal/reasoning ./internal/config ./internal/agentruntimepassed.Tests use local gateway fixtures. The originally reported third-party service was not tested directly, so this PR does not claim to establish the rejected field for that incident.