Add variables to adjust settings in one place#5
Open
patatman wants to merge 1 commit intoAM-STUDIO:masterfrom
Open
Add variables to adjust settings in one place#5patatman wants to merge 1 commit intoAM-STUDIO:masterfrom
patatman wants to merge 1 commit intoAM-STUDIO:masterfrom
Conversation
Author
|
Oh, and should you accept this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having some issues with adjusting the pins.
I'm using a Piksey Atto (which is the smallest Arduino you can get), and couldn't use the default pins.
Adjusting them looked straight forward, but got me into some issues.
This PR makes it easier to define custom pins.
I've made them a variable in the start of the code, and use those variables further down. This way when someone adjusts the pins, they only need to adjust the pin numbers in one place.
Fixes: #4