MultiFab: Fix Fixture Lifetime #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pytest fixtures are cached by default. That's not ideal for us, since we want to clean up and re-init AMReX and its memory arenas between tests. Thus, we now create a multifab fixture that is just a generator, so that the returned/yielded object can be cached - but the generated MultiFab is actually destroyed as we would expect once the test finishes.
ax3l
force-pushed
the
fix-mfab-fixture-lifetime
branch
from
77a7442 to
6b919a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest fixtures are cached by default. That's not ideal for us, since we want to clean up and re-init AMReX and its memory arenas between tests that run in the same process.
Thus, we now create a multifab fixture that is just a generator, so that the returned/yielded fixture variable (the generator) can be cached - but the generated MultiFab is actually destroyed as we would expect once each test finishes.
Refs.: