Skip to content

fix(fetch): Include revision in hashing for pypi #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

fix(fetch): Include revision in hashing for pypi #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion acbs/fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ def fetch_source(info: List[ACBSSourceInfo], source_location: str, package_name:
# in generate mode, we need to fetch all the sources
if not i.enabled and not generate_mode:
logging.info(f'Source {count} skipped.')
url_hash = hash_url(i.url)
# special handling for PyPI type
url = i.url if i.type != "pypi" else f"pypi://{i.url}/{i.revision}"
url_hash = hash_url(url)
fetch_source_inner(i, source_location, url_hash)
return None

Expand Down