Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

248 password visiblity keyboard overlap issue #249

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

navaneeth0041
Copy link
Contributor

Description

This PR addresses two UX issues in the LoginViewMobile page:

  1. Password field was showing characters by default instead of being obscured, which is a security concern
  2. On-screen keyboard was overlapping with input fields, making text entry difficult

The changes implement proper password field behavior and improve form accessibility on mobile devices.

Fixes #248

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The following test scenarios were performed on a mobile device:

  1. Password Field Testing:

    • Verified password field starts obscured by default
    • Tested visibility toggle button functionality
  2. Keyboard Interaction Testing:

    • Tested form field focus behavior
    • Verified keyboard appearance doesn't overlap with active input field
    • Confirmed smooth scrolling when switching between email and password fields
WhatsApp.Video.2025-01-29.at.00.14.03.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@navaneeth0041 navaneeth0041 requested a review from jddeep as a code owner January 28, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix password visibility and keyboard overlap issues in LoginViewMobile
1 participant